[bug report] ipv6: implement dataplane support for rthdr type 4 (Segment Routing Header)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello David Lebrun,

The patch 1ababeba4a21: "ipv6: implement dataplane support for rthdr
type 4 (Segment Routing Header)" from Nov 8, 2016, leads to the
following static checker warning:

	net/ipv6/exthdrs.c:391 ipv6_srh_rcv()
	error: double free of 'skb'

net/ipv6/exthdrs.c
   384  
   385          if (hdr->segments_left >= (hdr->hdrlen >> 1)) {
   386                  __IP6_INC_STATS(net, ip6_dst_idev(skb_dst(skb)),
   387                                  IPSTATS_MIB_INHDRERRORS);
   388                  icmpv6_param_prob(skb, ICMPV6_HDR_FIELD,
                                          ^^^
Freed here.

   389                                    ((&hdr->segments_left) -
   390                                     skb_network_header(skb)));
   391                  kfree_skb(skb);
                                  ^^^
And again here.

   392                  return -1;
   393          }
   394  

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux