On Tue, 2017-04-18 at 22:14 +0300, Dan Carpenter wrote:
> This patch is prompted by a static checker warning about a potential
> use after free. The concern is that netif_rx_ni() can free "skb" and
> we
> call it twice.
>
> When I look at the commit that added this, it looks like some stray
> lines were added accidentally. It doesn't make sense to me that we
> would recieve the same data two times. I asked the author but never
> recieved a response.
>
> I can't test this code, but I'm pretty sure my patch is correct.
Sorry for not getting back earlier, I have swamped with other stuff.
You are correct that these lines was added accidentally.
Acked-by: Stefan Sørensen <stefan.sorensen@xxxxxxxxxxxxxxx>
>
> Fixes: 4b063258ab93 ("dp83640: Delay scheduled work.")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
> index e2460a57e4b1..ed0d10f54f26 100644
> --- a/drivers/net/phy/dp83640.c
> +++ b/drivers/net/phy/dp83640.c
> @@ -1438,8 +1438,6 @@ static bool dp83640_rxtstamp(struct phy_device
> *phydev,
> skb_info->tmo = jiffies + SKB_TIMESTAMP_TIMEOUT;
> skb_queue_tail(&dp83640->rx_queue, skb);
> schedule_delayed_work(&dp83640->ts_work,
> SKB_TIMESTAMP_TIMEOUT);
> - } else {
> - netif_rx_ni(skb);
> }
>
> return true;��.n��������+%������w��{.n����z�ޗ�����n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
