[PATCH 2/3] ACPI/int340x_thermal: Improve size determinations in two functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 10 Apr 2017 21:42:44 +0200

Replace the specification of two data types by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determinations a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
 drivers/thermal/int340x_thermal/acpi_thermal_rel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/int340x_thermal/acpi_thermal_rel.c b/drivers/thermal/int340x_thermal/acpi_thermal_rel.c
index 52a5fe0f81e8..d7791b1fec33 100644
--- a/drivers/thermal/int340x_thermal/acpi_thermal_rel.c
+++ b/drivers/thermal/int340x_thermal/acpi_thermal_rel.c
@@ -247,7 +247,7 @@ static int fill_art(char __user *ubuf)
 	ret = acpi_parse_art(acpi_thermal_rel_handle, &count, &arts, false);
 	if (ret)
 		goto free_art;
-	art_len = count * sizeof(union art_object);
+	art_len = count * sizeof(*art_user);
 	art_user = kzalloc(art_len, GFP_KERNEL);
 	if (!art_user) {
 		ret = -ENOMEM;
@@ -283,7 +283,7 @@ static int fill_trt(char __user *ubuf)
 	ret = acpi_parse_trt(acpi_thermal_rel_handle, &count, &trts, false);
 	if (ret)
 		goto free_trt;
-	trt_len = count * sizeof(union trt_object);
+	trt_len = count * sizeof(*trt_user);
 	trt_user = kzalloc(trt_len, GFP_KERNEL);
 	if (!trt_user) {
 		ret = -ENOMEM;
-- 
2.12.2

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux