On Fri, Mar 24, 2017 at 8:13 AM, SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote: >>> Omit an extra message for a memory allocation failure in this function. >>> >>> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf >>> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> >>> --- >>> security/selinux/ss/policydb.c | 5 +---- >>> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> I'm not going to remove an error message without some better reasoning >> in the patch description. Providing a link to slides is fine, but >> your commit message needs to convey the important information and I >> don't think that is the case here (what happens when that URL dies?). > > Do you need an explicit reminder there that the function “kmalloc” provides its own > error reporting already because the flag “__GFP_NOWARN” was not passed here? That is what I said by "better reasoning in the patch description", however, now that I'm looking at this again, I don't think I'm going to merge this. Yes, maybe in some cases it is a bit wasteful, but I like the error message. -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
