Re: [PATCH 22/26] IB/ocrdma: Returning only value constants in ocrdma_resize_cq()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Acked-By:Devesh Sharma <devesh.sharma@xxxxxxxxxxxx>

On Wed, Mar 8, 2017 at 6:56 PM, SF Markus Elfring
<elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 8 Mar 2017 10:48:24 +0100
>
> Return constant integer values without storing them in the local
> variable "status".
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> index bedc229be89d..1d25512416f5 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> @@ -1123,15 +1123,12 @@ struct ib_cq *ocrdma_create_cq(struct ib_device *ibdev,
>  int ocrdma_resize_cq(struct ib_cq *ibcq, int new_cnt,
>                      struct ib_udata *udata)
>  {
> -       int status = 0;
>         struct ocrdma_cq *cq = get_ocrdma_cq(ibcq);
>
> -       if (new_cnt < 1 || new_cnt > cq->max_hw_cqe) {
> -               status = -EINVAL;
> -               return status;
> -       }
> +       if (new_cnt < 1 || new_cnt > cq->max_hw_cqe)
> +               return -EINVAL;
>         ibcq->cqe = new_cnt;
> -       return status;
> +       return 0;
>  }
>
>  static void ocrdma_flush_cq(struct ocrdma_cq *cq)
> --
> 2.12.0
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux