Re: [PATCH] iio: adc: xilinx: Fix error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 20/02/2017 à 09:35, Lars-Peter Clausen a écrit :
On 02/19/2017 09:29 PM, Christophe JAILLET wrote:
Reorder error handling labels in order to match the way resources have
been allocated.

Signed-off-by: Christophe JAILLET <christophe.jaillet-39ZsbGIQGT5GWvitb5QawA@xxxxxxxxxxxxxxxx>
Thanks, looks good.

Acked-by: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@xxxxxxxxxxxxxxxx>

I think there is one more issue

     ret = xadc->ops->setup(pdev, indio_dev, irq);
     if (ret)
         goto err_free_samplerate_trigger;

should be

	goto err_clk_disable_unprepare;

I agree.

Would you like me to send a V2 with both fixes or a sepparate patch?

CJ

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux