On Wed, Feb 8, 2017 at 4:58 PM, Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Feb 07, 2017 at 04:50:08PM +0300, Dan Carpenter wrote:
>> On Tue, Feb 07, 2017 at 02:42:15PM +0100, Maxime Ripard wrote:
>> > > - if (!IS_ERR(i2s->rst)) {
>> > > - ret = reset_control_deassert(i2s->rst);
>> > > - if (ret) {
>> > > - dev_err(&pdev->dev,
>> > > - "Failed to deassert the reset control\n");
>> > > - return -EINVAL;
>> > > - }
>> > > + ret = reset_control_deassert(i2s->rst);
>> > > + if (ret) {
>> > > + dev_err(&pdev->dev,
>> > > + "Failed to deassert the reset control\n");
>> > > + return -EINVAL;
>> >
>> > In the case where has_reset is false, rst is NULL and will trigger a
>> > WARN_ON in reset_control_deassert.
>> >
>>
>> No it won't. reset_control_deassert(NULL) just returns success
>> immediately.
>
> Not in current Linus' tree at least:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/reset/core.c#n217
The changes were just pulled into arm-soc. I suggest waiting for -rc1 at least
before merging this change.
ChenYu
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
