On ti, 2017-02-07 at 16:16 +0300, Dan Carpenter wrote:
> If "caps.buf" is already NULL then it doesn't need to be freed or set to
> NULL.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
<SNIP>
> @@ -965,11 +965,8 @@ static long intel_vgpu_ioctl(struct mdev_device *mdev, unsigned int cmd,
> sparse->areas[0].offset =
> PAGE_ALIGN(vgpu_aperture_offset(vgpu));
> sparse->areas[0].size = vgpu_aperture_sz(vgpu);
> - if (!caps.buf) {
Looking at the code around, the right thing would be to just remove the
negation? This currently seems like a memory leak.
> - kfree(caps.buf);
> - caps.buf = NULL;
> + if (!caps.buf)
> caps.size = 0;
> - }
And quickly looking, the caps is pre-initialized but unused at this
point, so the whole if could just be removed, right?
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
