On Fri, 27 Jan 2017, Mimi Zohar wrote: > On Wed, 2017-01-25 at 10:34 +0100, SF Markus Elfring wrote: > > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > > Date: Tue, 24 Jan 2017 22:47:07 +0100 > > > > A local variable was set to an error code in three cases before a concrete > > error situation was detected. Thus move the corresponding assignments into > > if branches to indicate a software failure there. > > > > This issue was detected by using the Coccinelle software. > > This coding style was pretty common. I assume the compiler is smart > enough to do the right thing. Is this a FYI, letting us know for the > future the preferred coding style, or are we really upstreaming these > sorts of coding style changes? Nope, and I generally don't want cleanup patches from Markus going into the security tree. See also: https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg1254425.html - James -- James Morris <jmorris@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
