The kmalloc(sizeof(struct foo), ...) => kmalloc(sizeof(*foo), ...) ones are OK. The rest is cargo-cult programming. Jeff -- Jeff Dike AddToIt 978-254-0789 (o) 978-394-8986 (c) -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html