>> @@ -2015,7 +2015,7 @@ static int genfs_read(struct policydb *p, void *fp) >> newgenfs = kzalloc(sizeof(*newgenfs), GFP_KERNEL); >> if (!newgenfs) { >> rc = -ENOMEM; >> - goto out; >> + goto exit; >> } >> >> rc = str_read(&newgenfs->fstype, GFP_KERNEL, fp, len); >> @@ -2101,7 +2101,7 @@ static int genfs_read(struct policydb *p, void *fp) >> kfree(newgenfs); >> } >> ocontext_destroy(newc, OCON_FSUSE); >> - >> +exit: >> return rc; > > Why not replace the "goto out" with "return rc" rather > than add a target? Would you accept to use the statement "return -ENOMEM;" there instead? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html