Re: [patch linux-next] userfaultfd: hugetlbfs: unmap the correct pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri 13-01-17 11:16:10, Dan Carpenter wrote:
> On Thu, Jan 12, 2017 at 08:33:27PM +0100, Michal Hocko wrote:
> > On Thu 12-01-17 22:20:52, Dan Carpenter wrote:
> > > kunmap_atomic() and kunmap() take different pointers.  People often get
> > > these mixed up.
> > > 
> > > Fixes: 16374db2e9a0 ("userfaultfd: hugetlbfs: fix __mcopy_atomic_hugetlb retry/error processing")
> > 
> > This looks like a linux-next sha1. This is not stable and will change...
> > 
> 
> Yeah.  But probably Andrew is just going to fold it into the original
> anyway.  Probably most of linux-next trees don't rebase so the hash is
> good and the people who rebase fold it in so it doesn't show up in the
> released code.  It basically never hurts to have the Fixes tag.

Yeah, I have a vague recollection that some of those sha1 leaked to
Linus. Do not have any examples handy though. It is true that Andrew
folds those fixes into the original patch so it might be helpful to
have
Fixes: mmotm-patch-file-name.patch
instead.

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux