Re: [patch 3/3] vfio-mdev: remove some dead code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



CC += Alex.

I think I wrote some code and then removed it, but forgot to remove this
code. Thanks for cleaning up.

Reviewed by: Kirti Wankhede <kwankhede@xxxxxxxxxx>

Thanks,
Kirti

On 1/7/2017 12:00 PM, Dan Carpenter wrote:
> We set info.count to 1 in mtty_get_irq_info() so static checkers
> complain that, "Why do we have impossible conditions?"  The answer is
> that it seems to be left over dead code that can be safely removed.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c
> index 353666d68207..d6ddc31fa729 100644
> --- a/samples/vfio-mdev/mtty.c
> +++ b/samples/vfio-mdev/mtty.c
> @@ -1230,9 +1230,6 @@ static long mtty_ioctl(struct mdev_device *mdev, unsigned int cmd,
>  		if (ret)
>  			return ret;
>  
> -		if (info.count == -1)
> -			return -EINVAL;
> -
>  		if (copy_to_user((void __user *)arg, &info, minsz))
>  			return -EFAULT;
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux