Hi Markus, On Mon, Dec 26, 2016 at 09:41:19PM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Mon, 26 Dec 2016 21:30:12 +0100 > > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (8): > v4l2-async: Use kmalloc_array() in v4l2_async_notifier_unregister() > v4l2-async: Delete an error message for a failed memory allocation in v4l2_async_notifier_unregister() > videobuf-dma-sg: Use kmalloc_array() in videobuf_dma_init_user_locked() > videobuf-dma-sg: Adjust 24 checks for null values > videobuf-dma-sg: Move two assignments for error codes in __videobuf_mmap_mapper() > videobuf-dma-sg: Improve a size determination in __videobuf_mmap_mapper() > videobuf-dma-sg: Delete an unnecessary return statement in videobuf_vm_close() > videobuf-dma-sg: Add some spaces for better code readability in videobuf_dma_init_user_locked() I don't really disagree with the videobuf changes as such --- the original code sure seems quite odd, but I wonder whether we want to do this kind of cleanups in videobuf. Videobuf will be removed likely in not too distant future; when exactly, Hans can guesstimate better than me. Cc him. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
