Hello,
Le 16/12/2016 à 10:33, Dan Carpenter a écrit :
We need "irq" to be an int because platform_get_irq() returns negative
error codes.
Fixes: 5762ab71eb24 ("spi: Add support for Armada 3700 SPI Controller")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c
index e89da0af45d2..5c7508dc6f0b 100644
--- a/drivers/spi/spi-armada-3700.c
+++ b/drivers/spi/spi-armada-3700.c
@@ -108,7 +108,7 @@ struct a3700_spi {
struct spi_master *master;
void __iomem *base;
struct clk *clk;
- unsigned int irq;
+ int irq;
unsigned int flags;
bool xmit_data;
const u8 *tx_buf;
It is already fixed, see
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=f6f0083cca66e673cca6fa26b52b107b5570081d
And no we cannot just replace the type of the irq field like this
because devm_request_irq/request_irq require an unsigned int as "irq"
parameter.
Romain
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
