On Wed, Dec 07, 2016 at 04:20:06PM +0100, Quentin Lambert wrote: > Hi all, > > I am looking at the drivers/staging/lustre/lustre/llite/dir.c: > > 1469 /* Call mdc_iocontrol */ > 1470 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp, > sizeof(fid), &fid, > 1471 &index); > 1472 if (rc) > > and sparse says: > > drivers/staging/lustre/lustre/llite/dir.c:1471:37: warning: > incorrect type in argument 5 (different address spaces) > > I was wondering if there was any value to add a cast to fix the warning? > And I guess this solution would also apply in my original patch to > > drivers/staging/lustre/lnet/lnet/lib-socket.c Just leave these alone until someone can come clean it up properly. Warnings are good! People have spent years and years to create programs to print warnings. Don't silence the warning by adding a cast. The warning means show that the code is dangerous. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
