On Wed, Nov 30, 2016 at 10:53 PM, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> On Wed, Nov 30, 2016 at 8:22 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>> We should return -EINVAL if get_cpu_device() fails.
>>
>> Fixes: 158c998ea44b ("ACPI / CPPC: add sysfs support to compute delivered performance")
>> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>>
>> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
>> index d0d0504..e0ea8f5 100644
>> --- a/drivers/acpi/cppc_acpi.c
>> +++ b/drivers/acpi/cppc_acpi.c
>> @@ -784,8 +784,10 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr)
>>
>> /* Add per logical CPU nodes for reading its feedback counters. */
>> cpu_dev = get_cpu_device(pr->id);
>> - if (!cpu_dev)
>> + if (!cpu_dev) {
>> + ret = -EINVAL;
>
> ret is initialized here AFAICS.
>
> Do you that its value is not the right one?
This was supposed to be "Do you mean that ...", sorry.
>
>> goto out_free;
>> + }
>>
>> ret = kobject_init_and_add(&cpc_ptr->kobj, &cppc_ktype, &cpu_dev->kobj,
>> "acpi_cppc");
>> --
Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
