On Wed, 30 Nov 2016 21:27:07 +0300
Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Wed, Nov 30, 2016 at 09:36:46AM -0700, Alex Williamson wrote:
> > On Wed, 30 Nov 2016 08:06:12 +0100
> > Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote:
> >
> > > 'vfio_group_get_from_dev()' seems to return only NULL on error, not an error
> > > pointer.
> > >
> > > Fixes: 2169037dc322 ("vfio iommu: Added pin and unpin callback functions to vfio_iommu_driver_ops")
> > > Fixes: c086de818dd8 ("vfio iommu: Add blocking notifier to notify DMA_UNMAP")
> > >
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> > > ---
> >
> > Dan Carpenter proposed a nearly identical patch:
> >
> > http://www.spinics.net/lists/kvm/msg141468.html
> >
> > The difference is you return -ENODEV while Dan returns -EINVAL. I tend
> > to prefer -ENODEV to distinguish this error case versus validation of
> > the other parameters. This patch also identifies both commits
> > introducing these, so I'm inclined to take this one rather than Dan's
> > version. Dan & Kirti, I welcome any credits you'd like to apply to
> > this patch for identifying and reviewing the same issue. Thanks,
> >
>
> Could I get a Reported-by?
Sure thing, thanks,
Alex
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
