On Thu, Nov 24, 2016 at 01:22:24PM +0000, Edward Cree wrote: > On 24/11/16 11:16, Dan Carpenter wrote: > > We don't use ->heap_buf after commit 46d1efd852cc ("sfc: remove Software > > TSO") so let's remove the last traces. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > diff --git a/drivers/net/ethernet/sfc/net_driver.h b/drivers/net/ethernet/sfc/net_driver.h > > index f97f828..fd17bda 100644 > > --- a/drivers/net/ethernet/sfc/net_driver.h > > +++ b/drivers/net/ethernet/sfc/net_driver.h > > @@ -139,8 +139,6 @@ struct efx_special_buffer { > > * struct efx_tx_buffer - buffer state for a TX descriptor > > * @skb: When @flags & %EFX_TX_BUF_SKB, the associated socket buffer to be > > * freed when descriptor completes > > - * @heap_buf: When @flags & %EFX_TX_BUF_HEAP, the associated heap buffer to be > > - * freed when descriptor completes. > > Does that mean we can also remove EFX_TX_BUF_HEAP? Good point. I will resend. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html