The goto is correct. "rc" is already set to -EBUSY so there is no need to do anything with that. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c index c264f2d..59b4a41 100644 --- a/drivers/block/swim3.c +++ b/drivers/block/swim3.c @@ -1179,7 +1179,6 @@ static int swim3_add_device(struct macio_dev *mdev, int index) swim3_err("%s", "Couldn't request interrupt\n"); pmac_call_feature(PMAC_FTR_SWIM3_ENABLE, swim, 0, 0); goto out_unmap; - return -EBUSY; } init_timer(&fs->timeout); -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html