We obviously intended a bitwise AND here, not a logical one. Fixes: 8c978d059224 ("liquidio CN23XX: Mailbox support") Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c b/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c index 5309384..73696b42 100644 --- a/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c +++ b/drivers/net/ethernet/cavium/liquidio/octeon_mailbox.c @@ -301,7 +301,7 @@ int octeon_mbox_process_message(struct octeon_mbox *mbox) sizeof(struct octeon_mbox_cmd)); if (!mbox_cmd.msg.s.resp_needed) { mbox->state &= ~OCTEON_MBOX_STATE_REQUEST_RECEIVED; - if (!(mbox->state && + if (!(mbox->state & OCTEON_MBOX_STATE_RESPONSE_PENDING)) mbox->state = OCTEON_MBOX_STATE_IDLE; writeq(OCTEON_PFVFSIG, mbox->mbox_read_reg); -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html