On Wed, Nov 16, 2016 at 05:12:21PM +0300, Dan Carpenter wrote: > "np" is supposed to be set to NULL at the start. > > Fixes: 4a45d9669ac1 ("tpm: replace of_find_node_by_name() with dev of_node propert") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Colid King submitted a patch to fix this a couple of days ago so applied that. Anyway, thank you for noting this. > diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c > index 3af829f..904ed4a 100644 > --- a/drivers/char/tpm/tpm_of.c > +++ b/drivers/char/tpm/tpm_of.c > @@ -23,7 +23,7 @@ > > int read_log_of(struct tpm_chip *chip) > { > - struct device_node *np; > + struct device_node *np = NULL; > const u32 *sizep; > const u64 *basep; > struct tpm_bios_log *log; /Jarkko -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html