Re: [bug report] vxlan: keep flags and vni in network byte order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 11, 2016 at 02:12:03PM +0100, Jiri Benc wrote:
> On Fri, 11 Nov 2016 14:05:09 +0100, Jiri Benc wrote:
> > The static checker clearly can't understand endian conversion macros.
> > VXLAN_VNI_MASK is:
> > 
> > cpu_to_be32(VXLAN_VID_MASK << 8)
> > 
> > Thus on little endian, it becomes 0x00ffffff.

Ah right.

> 
> Btw, until the unspecified static checker you used is not fixed to
> resolve such macros correctly, it can't be really used to check the
> kernel source, yet alone to generate bug reports. It will trip over
> false positive in gazillion places.

Nope.  Just this one.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux