On 03/11/16 22:05, SF Markus Elfring wrote:
@@ -1091,7 +1091,7 @@ static int vpfe_enum_input(struct file *file, void *priv, return -EINVAL; } sdinfo = &vpfe_dev->cfg->sub_devs[subdev]; - memcpy(inp, &sdinfo->inputs[index], sizeof(struct v4l2_input)); + memcpy(inp, &sdinfo->inputs[index], sizeof(*inp));If I am not mistaken this can be written as: *inp = sdinfo->inputs[index]; Much better.At which position would you like to integrate a second approach for such a change from this patch series? * Do you expect me to send a "V2" for the whole series?
No, just for the patches I commented upon.
* Will an update step be appropriate if I would rebase it on other recently accepted suggestions?
You can base it on https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=for-v4.10a
That branch has all your other patches of this series merged and is part of a pull
request I posted yesterday. Hans
Regards, Markus
-- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
