Hi, On Sun, Oct 30, 2016 at 12:53:02PM +0100, Christophe JAILLET wrote: > BTW, memory allocation in 'sun4i_layers_init()' looks spurious, especially > the use of 'layer' in the for loop. > Just my 2 cents. What do you mean by it's spurious? > I also forgot to say that we could propagate the error code returned by > sun4i_layers_init instead of returning -EINVAL unconditionally Indeed. Can you send a patch for that? Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature
