On 10/24, Christophe JAILLET wrote: > clk_register_pll() can return ERR_PTR(-ENOMEM) so checking the return value > against NULL only is not correct. The code just doesn't propagate the error up to the caller. Instead the caller treats NULL as an error and non-NULL as valid. If the callee detects an error it hides it and returns NULL. > In order to fix it, update clk_register_pll() to always return an error > pointer in case of error and check the return value with IS_ERR. > > While at it, also fix a tab vs space in the surrounding code. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > --- > Un-compiled and un-tested. Please at least compile test patches. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
