On Mon, Oct 17, 2016 at 01:30:59PM +0200, SF Markus Elfring wrote: > >> Some data were printed into a sequence by six separate function calls. > >> Print the same data by a single function call instead. > > > > ... why? > > > > Beyond simply having fewer function calls, is there an upside? > > Will it matter to improve run time characteristics at this source code > place? I do not know. If that's not the aim of your existing patch, then I have no idea what you're trying to achieve. > > This makes it harder to see the relationship between the format strings > > and their associated data, and makes the code longer. > > Do you prefer an other layout for the passed data so that the increase > of line count in my update suggestion would look differently? I prefer the code as-is. Unless there's a compelling reason to change it. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
