On 10/13/2016 10:30 AM, Dan Carpenter wrote:
> We return success or possibly uninitialized values on these error paths
> instead of proper error codes.
>
> Fixes: 140623410536 ("mtd: spi-nor: Add driver for Cadence Quad SPI Flash Controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
Nice
Reviewed-by: Marek Vasut <marex@xxxxxxx>
> diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c
> index 944863b..d489fbd 100644
> --- a/drivers/mtd/spi-nor/cadence-quadspi.c
> +++ b/drivers/mtd/spi-nor/cadence-quadspi.c
> @@ -1077,12 +1077,14 @@ static int cqspi_setup_flash(struct cqspi_st *cqspi, struct device_node *np)
>
> /* Get flash device data */
> for_each_available_child_of_node(dev->of_node, np) {
> - if (of_property_read_u32(np, "reg", &cs)) {
> + ret = of_property_read_u32(np, "reg", &cs);
> + if (ret) {
> dev_err(dev, "Couldn't determine chip select.\n");
> goto err;
> }
>
> if (cs >= CQSPI_MAX_CHIPSELECT) {
> + ret = -EINVAL;
> dev_err(dev, "Chip select %d out of range.\n", cs);
> goto err;
> }
>
--
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
