[patch] x86/pkeys: seftests: off by one in sigsafe_printf()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



We want "len" to represent the number of characters printed not counting
the NUL terminator.  At most there will be "DPRINT_IN_SIGNAL_BUF_SIZE - 1"
characters printed.

Fixes: 5f23f6d082a9 ("x86/pkeys: Add self-tests")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

diff --git a/tools/testing/selftests/x86/pkey-helpers.h b/tools/testing/selftests/x86/pkey-helpers.h
index b202939..1f21661 100644
--- a/tools/testing/selftests/x86/pkey-helpers.h
+++ b/tools/testing/selftests/x86/pkey-helpers.h
@@ -36,8 +36,8 @@ static inline void sigsafe_printf(const char *format, ...)
 		 * len is amount that would have been printed,
 		 * but actual write is truncated at BUF_SIZE.
 		 */
-		if (len > DPRINT_IN_SIGNAL_BUF_SIZE)
-			len = DPRINT_IN_SIGNAL_BUF_SIZE;
+		if (len >= DPRINT_IN_SIGNAL_BUF_SIZE)
+			len = DPRINT_IN_SIGNAL_BUF_SIZE - 1;
 		write(1, dprint_in_signal_buffer, len);
 	}
 	va_end(ap);
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux