On Wed, Oct 12, 2016 at 09:52:39AM +0100, Russell King - ARM Linux wrote: > On Wed, Oct 12, 2016 at 09:21:03AM +0300, Dan Carpenter wrote: > > We store UNDEF_REG in a u8. It causes a problem in functions like > > stm32_tx_dma_complete() where we check "if (ofs->icr == UNDEF_REG)". > > > > Fixes: 3489187204eb ('serial: stm32: adding dma support') > > Correct form is: > > Fixes: 12-digit-hash ("summary line") When I originally created the Fixes tag format, I used single quotes. I don't remember why though and I can change with the times. :) regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html