[bug report] rxrpc: Add some additional call tracing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello David Howells,

The patch a84a46d73050: "rxrpc: Add some additional call tracing"
from Sep 17, 2016, leads to the following static checker warning:

	net/rxrpc/call_object.c:279 rxrpc_new_client_call()
	warn: passing zero to 'ERR_PTR'

net/rxrpc/call_object.c
   270  
   271          /* Set up or get a connection record and set the protocol parameters,
   272           * including channel number and call ID.
   273           */
   274          ret = rxrpc_connect_call(call, cp, srx, gfp);
   275          if (ret < 0)
   276                  goto error;
   277  
   278          trace_rxrpc_call(call, rxrpc_call_connected, atomic_read(&call->usage),
   279                           here, ERR_PTR(ret));
                                       ^^^^^^^^^^^^
Pointless.

   280  

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux