re: qed: Add RoCE ll2 & GSI support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Ram Amrani,

This is a semi-automatic email about new static checker warnings.

The patch abd49676c707: "qed: Add RoCE ll2 & GSI support" from Oct 1, 
2016, leads to the following Smatch complaint:

drivers/net/ethernet/qlogic/qed/qed_roce.c:2812 qed_roce_ll2_stop()
	 warn: variable dereferenced before check 'cdev' (see line 2808)

drivers/net/ethernet/qlogic/qed/qed_roce.c
  2807	{
  2808		struct qed_hwfn *hwfn = QED_LEADING_HWFN(cdev);
  2809		struct qed_roce_ll2_info *roce_ll2 = hwfn->ll2;
                                                     ^^^^^^^^^
Deref.

  2810		int rc;
  2811	
  2812		if (!cdev) {
                    ^^^^^
Checked too late.

  2813			DP_ERR(cdev, "qed roce ll2 stop: invalid cdev\n");
  2814			return -EINVAL;

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux