[bug report] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Netanel Belgazal,

The patch 1738cd3ed342: "net: ena: Add a driver for Amazon Elastic
Network Adapters (ENA)" from Aug 10, 2016, leads to the following
static checker warning:

	drivers/net/ethernet/amazon/ena/ena_ethtool.c:459 ena_flow_hash_to_flow_type()
	warn: bitwise AND condition is false here

drivers/net/ethernet/amazon/ena/ena_ethtool.c
   454  
   455  static u32 ena_flow_hash_to_flow_type(u16 hash_fields)
   456  {
   457          u32 data = 0;
   458  
   459          if (hash_fields & ENA_ADMIN_RSS_L2_DA)
                                  ^^^^^^^^^^^^^^^^^^^
This is zero.

   460                  data |= RXH_L2DA;
   461  
   462          if (hash_fields & ENA_ADMIN_RSS_L3_DA)
   463                  data |= RXH_IP_DST;
   464  
   465          if (hash_fields & ENA_ADMIN_RSS_L3_SA)
   466                  data |= RXH_IP_SRC;
   467  
   468          if (hash_fields & ENA_ADMIN_RSS_L4_DP)
   469                  data |= RXH_L4_B_2_3;
   470  
   471          if (hash_fields & ENA_ADMIN_RSS_L4_SP)
   472                  data |= RXH_L4_B_0_1;
   473  
   474          return data;
   475  }


regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux