On Tue, Sep 06, 2016 at 04:34:13PM +0200, Jean Delvare wrote: > > [diff "default"] > > xfuncname = "^[[:alpha:]$_].*[^:]$" > > OK, I see. As mentioned somewhere else, it fails for labels which have > comments. Heh, There's labels that have comments? > My worry is that you recommending it to contributors on a individual > and opportunity basis, doesn't scale. Basing coding style > recommendations on a personal quirk doesn't strike me as the best idea > ever in the long run. Don't care too much, I simply will not take any patch that adds stupid spaces :-) > While looking at the syntax of your example, I have found something > which looks more promising. git already has predefined xfuncname > definitions for various languages, including C. These can be enabled > based on file name patterns via gitattributes. The > following .gitattribute file placed at the root of the kernel source > tree achieves what you want: > > *.c diff=cpp > *.h diff=cpp > > The major difference between git config and gitattributes is that the > latter can be part of the project itself, just like gitignore. So we > could just push that .gitattribute file upstream, and then labels > without leading spaces would no longer be a problem, at least within > git. Works for me, and last time this came up Linus agreed with the "whitespace before labels is stupid" thing. Although I cannot find a link to that just now. > It would still be a problem for me as an inveterate quilt user, Add the below to your .quiltrc or environment: QUILT_DIFF_OPTS="-F ^[[:alpha:]\$_].*[^:]\$" Same caveat about labels with comments, but then I'd not take a patch doing that in the first place. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
