From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Date: Mon, 5 Sep 2016 16:10:40 +0200 Move a function call into an else branch for successful function execution. Omit a duplicate check for the local variable "result" then at the end. Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> --- drivers/acpi/acpi_video.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c index fe9b40e..0362a43 100644 --- a/drivers/acpi/acpi_video.c +++ b/drivers/acpi/acpi_video.c @@ -1372,14 +1372,12 @@ acpi_video_switch_brightness(struct work_struct *work) level_next = acpi_video_get_next_level(device, level_current, event); result = acpi_video_device_lcd_set_level(device, level_next); - - if (!result) - backlight_force_update(device->backlight, - BACKLIGHT_UPDATE_HOTKEY); - out: if (result) printk(KERN_ERR PREFIX "Failed to switch the brightness\n"); + else + backlight_force_update(device->backlight, + BACKLIGHT_UPDATE_HOTKEY); } int acpi_video_get_edid(struct acpi_device *device, int type, int device_id, -- 2.10.0 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
