Hello,
SF Markus Elfring wrote:
: From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
: Date: Sat, 20 Aug 2016 10:10:12 +0200
:
: Reuse existing functionality from memdup_user() instead of keeping
: duplicate source code.
:
: This issue was detected by using the Coccinelle software.
What about the GFP_DMA attribute, which your patch deletes?
The buffer in question has to be ISA DMA-able.
Anyway, COSA is an ancient ISA device, which is out of production
for at least 10 years. I don't have a box with ISA bus anymore, so I can't
even test the modifications of the wan/cosa.c (I do have a COSA board
itself, though :-).
I suggest keeping the driver intact if possible, in case somebody
still uses it.
Sincerely,
-Yenya
: Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
: ---
: drivers/net/wan/cosa.c | 12 +++---------
: 1 file changed, 3 insertions(+), 9 deletions(-)
:
: diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
: index b87fe0a..02f5809 100644
: --- a/drivers/net/wan/cosa.c
: +++ b/drivers/net/wan/cosa.c
: @@ -875,16 +875,10 @@ static ssize_t cosa_write(struct file *file,
: if (count > COSA_MTU)
: count = COSA_MTU;
:
: - /* Allocate the buffer */
: - kbuf = kmalloc(count, GFP_KERNEL|GFP_DMA);
: - if (kbuf == NULL) {
: + kbuf = memdup_user(buf, count);
: + if (IS_ERR(kbuf)) {
: up(&chan->wsem);
: - return -ENOMEM;
: - }
: - if (copy_from_user(kbuf, buf, count)) {
: - up(&chan->wsem);
: - kfree(kbuf);
: - return -EFAULT;
: + return PTR_ERR(kbuf);
: }
: chan->tx_status=0;
: cosa_start_tx(chan, kbuf, count);
: --
: 2.9.3
--
| Jan "Yenya" Kasprzak <kas at {fi.muni.cz - work | yenya.net - private}> |
| http://www.fi.muni.cz/~kas/ GPG: 4096R/A45477D5 |
Like most things in Windows, on the surface it looks great.
-- Jeremy Allison, A Tale of Two Standards
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
