Re: [PATCH 2/2] be2iscsi: Fix some error messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le 12/08/2016 à 12:30, Julia Lawall a écrit :
On Fri, 12 Aug 2016, Christophe JAILLET wrote:

This fixes:
    - missing spaces in string split on several lines
    - extra spaces after ':'
    - missing '\n' at the end of some messages
    - too long lines
I think that the strings should be concatenated, even if they go past 80
chars.  I'm surprised checkpatch didn't complain.

julia

checkpatch did complain.
In this file, all logging messages were written with split lines when too long, so I considered that it was better to keep it like that.

I will resubmit if the patch gets some interest and if a maintainer ask for concatenated messages.

CJ

---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux