On Thu, 11 Aug 2016, SF Markus Elfring wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Thu, 11 Aug 2016 14:00:43 +0200 > > Delete an error message at the end while increasing the importance of > related information. > > Link: https://lkml.kernel.org/g/<20160809153615.GU5243@dell> > Suggested-by: Lee Jones <lee.jones@xxxxxxxxxx> > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > > v5: Rebased on the source files from Linux next-20160809. > > Requested changes were applied. > > drivers/mfd/dm355evm_msp.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c > index 86eca61..463f9e2e 100644 > --- a/drivers/mfd/dm355evm_msp.c > +++ b/drivers/mfd/dm355evm_msp.c > @@ -208,7 +208,7 @@ static struct device *add_child(struct i2c_client *client, const char *name, > if (pdata) { > status = platform_device_add_data(pdev, pdata, pdata_len); > if (status < 0) { > - dev_dbg(&pdev->dev, "can't add platform_data\n"); > + dev_err(&pdev->dev, "can't add platform_data\n"); Isn't this message unnecessary? platform_device_add_data only fails on failure of kmemdup, which I assume ends up in kmalloc eventually and prints a backtrace on failure. The same is true of platform_device_add_resources below. julia > goto put_device; > } > } > @@ -221,7 +221,7 @@ static struct device *add_child(struct i2c_client *client, const char *name, > > status = platform_device_add_resources(pdev, &r, 1); > if (status < 0) { > - dev_dbg(&pdev->dev, "can't add irq\n"); > + dev_err(&pdev->dev, "can't add irq\n"); > goto put_device; > } > } > @@ -234,7 +234,6 @@ static struct device *add_child(struct i2c_client *client, const char *name, > > put_device: > platform_device_put(pdev); > - dev_err(&client->dev, "failed to add device %s\n", name); > return ERR_PTR(status); > } > > -- > 2.9.2 > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
