On Tue, Aug 09, 2016 at 06:32:55PM +0300, Andy Shevchenko wrote:
> On Fri, 2016-07-15 at 22:23 +0300, Dan Carpenter wrote:
> > Hello Andy Shevchenko,
> >
> > The patch 05f310e26fe9: "x86/sfi: Enable enumeration of SD devices"
> > from Jul 12, 2016, leads to the following static checker warning:
> >
> > arch/x86/platform/intel-mid/sfi.c:427 sfi_handle_sd_dev()
> > warn: 'pdata' isn't an ERR_PTR
> >
> > arch/x86/platform/intel-mid/sfi.c
> > 416 memset(&sd_info, 0, sizeof(sd_info));
> > 417 strncpy(sd_info.name, pentry->name, SFI_NAME_LEN);
> > 418 sd_info.bus_num = pentry->host_num;
> > 419 sd_info.max_clk = pentry->max_freq;
> > 420 sd_info.addr = pentry->addr;
> > 421 pr_debug("SD bus = %d, name = %16.16s, max_clk = %d,
> > addr = 0x%x\n",
> > 422 sd_info.bus_num,
> > 423 sd_info.name,
> > 424 sd_info.max_clk,
> > 425 sd_info.addr);
> > 426 pdata = intel_mid_sfi_get_pdata(dev, &sd_info);
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > This is a macro calling a function pointer. None of the functions
> > return error pointers. Some return NULL on error but some return NULL
> > on success.
> >
> > 427 if (IS_ERR(pdata))
> > 428 return;
> > 429
> > 430 /* Nothing we can do with this for now */
> > 431 sd_info.platform_data = pdata;
> > 432
>
> Thanks for catching up this. At some point in the future I will re-check
> all those so called "device lib" files to be aligned to one standard. Of
> course you may propose a patch if you feel you can do it.
I'm a temporary haitus from work but what's the standard supposed
to be?
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
