On Fri, 5 Aug 2016, Sergei Shtylyov wrote: > Hello. > > On 8/5/2016 11:56 AM, Julia Lawall wrote: > > > Use of_property_read_bool to check for the existence of a property. > > > > The semantic patch that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > > > // <smpl> > > @@ > > expression e1,e2; > > statement S2,S1; > > @@ > > - if (of_get_property(e1,e2,NULL)) > > + if (of_property_read_bool(e1,e2)) > > S1 else S2 > > // </smpl> > > > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > > > > --- > > drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c > > b/drivers/net/ethernet/freescale/xgmac_mdio.c > > index 7b8fe86..a77ba98 100644 > > --- a/drivers/net/ethernet/freescale/xgmac_mdio.c > > +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c > > @@ -271,8 +271,7 @@ static int xgmac_mdio_probe(struct platform_device > > *pdev) > > goto err_ioremap; > > } > > > > - if (of_get_property(pdev->dev.of_node, > > - "little-endian", NULL)) > > + if (of_property_read_bool(pdev->dev.of_node, "little-endian")) > > priv->is_little_endian = true; > > else > > priv->is_little_endian = false; > > priv->is_little_endian = of_property_read_bool(pdev->dev.of_node, > "little-endian")); Thanks, I just sent a v2 with this change. julia -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
