On 08/04/2016, 07:34 AM, Dan Carpenter wrote:
> We already called "local_irq_restore(flags);" so this isn't needed.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
> index 208f573..2f33cf1 100644
> --- a/drivers/tty/amiserial.c
> +++ b/drivers/tty/amiserial.c
> @@ -880,7 +880,6 @@ static int rs_write(struct tty_struct * tty, const unsigned char *buf, int count
If I add a bit more context:
local_irq_disable();
custom.intena = IF_SETCLR | IF_TBE;
mb();
> /* set a pending Tx Interrupt, transmitter should restart now */
> custom.intreq = IF_SETCLR | IF_TBE;
> mb();
> - local_irq_restore(flags);
Really?
thanks,
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
