On Tue, Jul 12, 2016 at 4:22 PM, SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Tue, 12 Jul 2016 22:00:55 +0200 > > The drm_gem_object_unreference_unlocked() function tests whether > its argument is NULL and then returns immediately. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Applied. thanks! Alex > --- > drivers/gpu/drm/radeon/radeon_display.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c > index 5f1cd69..1efab5f 100644 > --- a/drivers/gpu/drm/radeon/radeon_display.c > +++ b/drivers/gpu/drm/radeon/radeon_display.c > @@ -1324,9 +1324,7 @@ static void radeon_user_framebuffer_destroy(struct drm_framebuffer *fb) > { > struct radeon_framebuffer *radeon_fb = to_radeon_framebuffer(fb); > > - if (radeon_fb->obj) { > - drm_gem_object_unreference_unlocked(radeon_fb->obj); > - } > + drm_gem_object_unreference_unlocked(radeon_fb->obj); > drm_framebuffer_cleanup(fb); > kfree(radeon_fb); > } > -- > 2.9.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html