Hi Markus, On Thu, 21 Jul 2016 09:55:55 +0200, SF Markus Elfring wrote: > > > How do you think about information from the chapter "7: Centralized exiting of functions"? > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/CodingStyle?id=47ef4ad2684d380dd6d596140fb79395115c3950#n389 > > > > I'm not impressed by this piece of documentation. > > I would also appreciate further improvements there. > > > > Back to the lack of space before labels, it's at best a personal preference. > > If you insist on standardizing, I'd call it a bug in the documentation, > > which should be fixed. One space before label is the way to go. > > Would you like to contribute another patch for such a coding style issue? I just sent a patch out, let's see what people think about it. > > That being said... checkpatch does not complain about leading space > > before labels. Not even with --strict. So why are you mentioning it here? > > How do you think about a similar software update? > > staging: lustre: Fix a jump label position in osc_get_info() > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=c71d264543f759fea147734cb63de36397817534 > https://lkml.org/lkml/2015/12/21/401 Intending labels with a tab is wrong, so fixing it is welcome. I'd turn the tab into a space instead, for reasons explained before, but no indentation at all is still better than a tab. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
