Error handling in drivers/pci/host/pci-dra7xx.c

Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> · Wed, 13 Jul 2016 06:59:32 +0200

(resent because of broken cc)

Hi,

in file 'drivers/pci/host/pci-dra7xx.c', error handling in 
'dra7xx_pcie_init_irq_domain()' seams to be broken.

The pattern used is:

   if (!var) {
      ...
      dev_err(...);
      return PTR_ERR(var);
   }

so we always return '0', which means success.

Returning PTR_ERR(-EINVAL) or PTR_ERR(-ENODEV) could be, IMHO, better.

Best regards,

CJ

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html