From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> Date: Mon, 4 Jul 2016 07:46:42 +0200 > This is likely that checking 'fman->fifo_offset' instead of > 'fman->cam_offset' is expected here. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> > --- > > The type of 'fifo_offset' may also need to be changed. Fix the test rather than trying to force it into the error pointer macro. If fifo_offset is not a pointer, then change the test to check for whatever would be appropriate for values returned from fman_muram_alloc(). This is a very low quality patch submission, you submitted a "fix" which added a new build warning and made it obvious that something else is needed as well here. You even stated that you realized this. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html