"val" can't be negative because it's unsigned and also readl() doesn't return negative error codes. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c index fb4c56c..8abc369 100644 --- a/drivers/remoteproc/qcom_q6v5_pil.c +++ b/drivers/remoteproc/qcom_q6v5_pil.c @@ -386,7 +386,6 @@ static int q6v5_mpss_validate(struct q6v5 *qproc, const struct firmware *fw) phys_addr_t fw_addr; bool relocate; size_t size; - u32 val; int ret; int i; @@ -425,8 +424,7 @@ static int q6v5_mpss_validate(struct q6v5 *qproc, const struct firmware *fw) writel(size, qproc->rmb_base + RMB_PMI_CODE_LENGTH_REG); } - val = readl(qproc->rmb_base + RMB_MBA_STATUS_REG); - return val < 0 ? val : 0; + return readl(qproc->rmb_base + RMB_MBA_STATUS_REG); } static int q6v5_mpss_load(struct q6v5 *qproc) -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
