> > drivers/net/ethernet/qlogic/qede/qede_ethtool.c
> > 429 static int qede_get_coalesce(struct net_device *dev,
> > 430 struct ethtool_coalesce *coal)
> > 431 {
> > 432 struct qede_dev *edev = netdev_priv(dev);
> > 433
> > 434 memset(coal, 0, sizeof(struct ethtool_coalesce));
> > 435 edev->ops->common->get_coalesce(edev->cdev,
> > 436 (u16 *)&coal->rx_coalesce_usecs,
> > 437 (u16 *)&coal->tx_coalesce_usecs);
> >
> > This won't work on big endian systems. Fix it so the function takes a
> > u32 or make ->rx_coalesce_usecs a u16.
> >
> given you do a memset before, what are the chances that coal-
> >rx_coalesce_usecs != 0 ?
> Is there a dynamic update in the background ?
It's a getter; The entire purpose of the `get_coalesce' function is to fill
those fields with actual values.
[Although I noticed that the memset is clearing the `cmd' field,
which isn't an intended result]
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
