On Fri, Jun 24, 2016 at 09:12:25PM +0800, Jeff Liu wrote: > Hi Dan, > > xfs_errortag_add() is called by xfs_file_ioctl(), which accept the 1st > argument as signed, i.e, > > typedef struct xfs_error_injection { > __s32 fd; > __s32 errtag; > } xfs_error_injection_t; > > Should we make it happy as well? Also, the typedef can be converted to > to struct xfs_error_injection by removing the depreciated > xfs_error_injection_t > syntax if so. That has been the user interface for a while so I didn't want to change it. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html