Re: [patch v2] PM / devfreq: exynos-nocp: Remove incorrect IS_ERR() check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Myungjoo,

On Wed, Jun 1, 2016 at 7:25 PM, MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx> wrote:
> On Thu, May 26, 2016 at 3:45 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>> Smatch complains because platform_get_resource() returns NULL on error
>> and not an error pointer so the check is wrong.  Julia Lawall pointed
>> out that normally we don't check these, because devm_ioremap_resource()
>> has a check for NULL.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> Acked-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
>
> Queued in fixes branch to be sent with other fixes for RCx.


I already reviewed this patch. Also, the merged patch[1] don't include
the my reviewed-by tag.
I'd like you to add my reviewed-by tag again.

[1] https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=fixes&id=44a3c02256bb69b2a20f55d2bd77c5a2fd20bc52

Regards,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux