On Wed, May 25, 2016 at 05:11:33PM +0200, Julia Lawall wrote:
>
>
> On Wed, 25 May 2016, Chanwoo Choi wrote:
>
> > On 2016년 05월 18일 19:37, Dan Carpenter wrote:
> > > The platform_get_resource() function returns NULL on error, it never
> > > returns error pointers.
> > >
> > > Fixes: 0179a913875a ('PM / devfreq: event: Add new Exynos NoC probe driver')
> > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > >
> > > diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c
> > > index 6b6a5f3..03b35d5 100644
> > > --- a/drivers/devfreq/event/exynos-nocp.c
> > > +++ b/drivers/devfreq/event/exynos-nocp.c
> > > @@ -220,8 +220,8 @@ static int exynos_nocp_parse_dt(struct platform_device *pdev,
> > >
> > > /* Maps the memory mapped IO to control nocp register */
> > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > - if (IS_ERR(res))
> > > - return PTR_ERR(res);
> > > + if (!res)
> > > + return -ENXIO;
> > >
> > > base = devm_ioremap_resource(dev, res);
> > > if (IS_ERR(base))
> >
> > Looks good to me.
>
> I believe that there is no need for the test at all.
> devm_ioremap_resource should make the test.
True. The static checker warning here is just that "res" isn't an error
pointer, not that we dereference it.
I'll resend.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
